On Sun, 26 Jul 2015, Steve Lhomme wrote:
On Sun, Jul 26, 2015 at 11:23 AM, Martin Storsjö <[email protected]> wrote:
On Sun, 26 Jul 2015, Martin Storsjö wrote:
From: Steve Lhomme <[email protected]>
The struct definitions in dxva.h, which are necessary in order to
actually use d3d11va, are hidden when WINAPI_FAMILY targets Windows Phone
or WindowsRT.
Since this is only struct definitions, it doesn't affect the runtime
compatibility.
Building with WINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP is disallowed
when targeting ARM. ("Compiling Desktop applications for the ARM
platform is not supported.")
Disable this error during the configure test. When actually building
the libavcodec source files, the header that causes the errors
(crtdefs.h or corecrt.h) has already been included before it is
redefined.
---
configure | 2 +-
libavcodec/dxva2_internal.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
Steve, if you're ok with this version (with
-D_ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE=1), I'll push it soon.
I think using -D_CRT_BUILD_DESKTOP_APP=0 is better, it may even be set
globally on the build and it has the same effect.
Thanks, that's probably just as good or better.
If it's not set globally, then we need to set this one or the other in
dxva2_internal.h.
At least in my tests, it wasn't necessary, because in each place
dxva2_internal.h is included, enough system headers have already been
included so the check has been performed (and won't be performed again).
But it doesn't hurt to add it there just in case, and that's of course
even better.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
