Quoting wm4 (2015-09-27 21:46:29) > On Sun, 27 Sep 2015 21:11:37 +0200 > Anton Khirnov <[email protected]> wrote: > > > Quoting Vittorio Giovara (2015-09-27 02:41:43) > > > This field was used in combination with coded_frame to compute some > > > sort of PSNR value. Regardless of its use, this property is tied to the > > > encoding processing, while AVFrame is a structure suited for decoded > > > data only. > > > > > > The only use of this field (besides the deprecated coded_frame) is > > > in mpegvideoenc: since it might be used in bframes estimation, add an > > > additional field to Picture, which is a private structure anyway. > > > > While I'm all for removing crap, this commit message is very misleading. > > The fact is that error is used for _exporting_ some information to the > > user. This is done through coded_frame, which someone deprecated, but > > did not provide a replacement for this field. And now the commit message > > is trying to somehow pretend that AVFrame.error[] has always been an > > unperson and we were always at war with eastasia. > > > > That is not good practice IMO. If you're deprecating crap that nobody > > should use, just say so, don't cover it under a wall of euphemisms. That > > way people people can actually see what's going on here and > > object/suggest alternative ways or whatever. > > > > Now the prize question: does anyone use it?
Other than the mpegvideo encoder itself? Probably not. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
