Quoting Mark Thompson (2016-03-16 00:00:39)
> ---
>  configure                 |   2 +
>  libavcodec/Makefile       |   1 +
>  libavcodec/vaapi_encode.c | 951 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vaapi_encode.h | 203 ++++++++++
>  4 files changed, 1157 insertions(+)
>  create mode 100644 libavcodec/vaapi_encode.c
>  create mode 100644 libavcodec/vaapi_encode.h

One important-ish thing is that you're not setting dts at all, and since
the actual encoders are not marked with CAP_DELAY, the generic code sets
dts=pts. That will be wrong with b-frames and I think should not be hard
to fix.

Also, you should check on init that the hwcontext is actually set and
fail gracefully, now it will just crash I think.

Finally, you're logging to the private data context, it should properly
be the AVCodecContext.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to