On Thu, Mar 17, 2016 at 08:48:56PM +0000, Mark Thompson wrote: > On 17/03/16 10:47, Diego Biurrun wrote: > > On Tue, Mar 15, 2016 at 11:00:39PM +0000, Mark Thompson wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -1874,6 +1875,7 @@ nvenc_deps_any="dlopen LoadLibrary" > >> nvenc_extralibs='$ldl' > >> qsvdec_select="qsv" > >> qsvenc_select="qsv" > >> +vaapi_encode_deps="vaapi" > >> vc1dsp_select="h264chroma qpeldsp startcode" > > > > A better place for this would be right next to the vaapi decoding entry. > > Can you suggest more precisely where you mean (there is no vaapi > decoder). Are you referring to the hwaccel decoding section?
Yes, I meant the hwaccel section; I believe it is better suited to contain the hw-accelerated decoders/encoders as well. > What I had here was modelled on qsv. Yes; you could argue that it's out of scope to clean up that section. > >> --- /dev/null > >> +++ b/libavcodec/vaapi_encode.h > >> @@ -0,0 +1,203 @@ > >> + > >> +#include <va/va.h> > >> + > >> +#include "libavutil/hwcontext.h" > >> +#include "libavutil/hwcontext_vaapi.h" > >> + > >> +#include "avcodec.h" > >> +#include "put_bits.h" > > > > The last two headers seem unused, but you need at least stdint.h and > > frame.h. > > put_bits.h is unused now, removed. > > What are you actually asking for with avcodec.h: Nothing, I misread. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
