On 21/03/16 13:02, Diego Biurrun wrote: > On Mon, Mar 21, 2016 at 12:47:46PM +0000, Mark Thompson wrote: >> Referring back to a previous response, can you offer any guidance about how >> you >> think the "vaapi", "vaapi_encode" etc. config options should be arranged? >> (Including replacing existing "vaapi" with "vaapi_decode", I think.) > > Sorry, I'm missing context here. Could you please reply to that other > response to help jog my failing memory?
Below. Meanings being something like: VAAPI: hwcontext support, avconv, scale filter. VAAPI_DECODE: decode support, hwaccels. VAAPI_ENCODE: encode support, encoder instances. (Maybe avconv should be some other combination; currently it requires X11 or DRM to actually work (it can't get a device handle without one of those), though they aren't build dependencies.) - Mark On 18/03/16 10:45, Mark Thompson wrote: > On 17/03/16 20:48, Mark Thompson wrote: >> On 17/03/16 10:47, Diego Biurrun wrote: >>> On Tue, Mar 15, 2016 at 11:00:39PM +0000, Mark Thompson wrote: >>>> --- a/configure >>>> +++ b/configure >>>> @@ -1874,6 +1875,7 @@ nvenc_deps_any="dlopen LoadLibrary" >>>> nvenc_extralibs='$ldl' >>>> qsvdec_select="qsv" >>>> qsvenc_select="qsv" >>>> +vaapi_encode_deps="vaapi" >>>> vc1dsp_select="h264chroma qpeldsp startcode" >>> >>> A better place for this would be right next to the vaapi decoding entry. >> >> Can you suggest more precisely where you mean (there is no vaapi decoder). >> Are you referring to the hwaccel decoding section? >> >> What I had here was modelled on qsv. > > A little more thought on this - it might be better to split the current > "vaapi" > config option into "vaapi" (which gives you the hwcontext code, and is a > dependency of everything else) and "vaapi_decode" (or "vaapi_hwaccel" which > gives you the lavc decode part to support the hwaccels). That then fits with > the suggested "vaapi_encode" option, and the two separate parts can be used > independently. > > >>>> --- a/libavcodec/Makefile >>>> +++ b/libavcodec/Makefile >>>> @@ -105,6 +105,7 @@ OBJS-$(CONFIG_STARTCODE) += startcode.o >>>> OBJS-$(CONFIG_TEXTUREDSP) += texturedsp.o >>>> OBJS-$(CONFIG_TEXTUREDSPENC) += texturedspenc.o >>>> OBJS-$(CONFIG_TPELDSP) += tpeldsp.o >>>> +OBJS-$(CONFIG_VAAPI_ENCODE) += vaapi_encode.o >>>> OBJS-$(CONFIG_VC1DSP) += vc1dsp.o >>>> OBJS-$(CONFIG_VIDEODSP) += videodsp.o >>>> OBJS-$(CONFIG_VP3DSP) += vp3dsp.o >>> >>> same > > Some stuff in this Makefile would be rearranged too - vaapi.o would depend on > CONFIG_VAAPI_DECODE (and should maybe be renamed, though inconveniently > vaapi.h > is a user-visible header). _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
