On Mon, Mar 21, 2016 at 01:18:11PM +0100, Anton Khirnov wrote:
> Quoting Diego Biurrun (2016-03-21 13:16:12)
> > On Mon, Mar 21, 2016 at 12:02:41AM +0000, Mark Thompson wrote:
> > > --- /dev/null
> > > +++ b/avconv_vaapi.c
> > > @@ -0,0 +1,626 @@
> > > +
> > > +static void vaapi_device_uninit(AVHWDeviceContext *hwdev)
> > > +{
> > > +}
> > > +
> > > +int vaapi_device_init(const char *device)
> > > +{
> > > +}
> >
> > Are these two functions candidates for av_cold?
> >
> > > --- a/configure
> > > +++ b/configure
> > > @@ -4689,6 +4690,10 @@ enabled vaapi && enabled xlib &&
> > > check_lib2 "va/va.h va/va_x11.h" vaGetDisplay -lva -lva-x11 &&
> > > enable vaapi_x11
> > >
> > > +enabled vaapi &&
> > > + check_lib2 "va/va.h va/va_drm.h" vaGetDisplayDRM -lva -lva-drm &&
> > > + enable vaapi_drm
> >
> > Merging the two vaapi blocks would be cleaner IMO.
>
> Merging how? They enable two different things.
pseudocode:
if enabled vaapi {
check one thing;
check another thing;
}
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
