On Mon, Mar 21, 2016 at 12:04:23AM +0000, Mark Thompson wrote:
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -105,7 +105,7 @@ OBJS-$(CONFIG_STARTCODE) += startcode.o
> OBJS-$(CONFIG_TEXTUREDSP) += texturedsp.o
> OBJS-$(CONFIG_TEXTUREDSPENC) += texturedspenc.o
> OBJS-$(CONFIG_TPELDSP) += tpeldsp.o
> -OBJS-$(CONFIG_VAAPI_ENCODE) += vaapi_encode.o
> +OBJS-$(CONFIG_VAAPI_ENCODE) += vaapi_encode.o vaapi_encode_h26x.o
Is vaapi_encode_h26x.o required by your MJPEG encoder as well? If not,
then this object file should not be compiled for it. You can add
another vaapi_encode_h26x component that conditionally enables it.
> --- /dev/null
> +++ b/libavcodec/vaapi_encode_h264.c
> @@ -0,0 +1,817 @@
> +
> +typedef struct {
> +} VAAPIEncodeH264MiscSliceParams;
Please avoid anonymously typedeffed structs.
> --- /dev/null
> +++ b/libavcodec/vaapi_encode_h26x.h
> @@ -0,0 +1,70 @@
> +
> +// Set to 1 to log a full trace of all bitstream output (debugging only).
> +#if 0
Ugh, commented out code tends to rot and break... :-/
> +static void trace_write_u(PutBitContext *pbc, unsigned int width,
> + unsigned int value, const char *name)
Can't this be achieved through the TRACE loglevel?
Diego
> +int ff_vaapi_encode_h26x_nal_unit_to_byte_stream(uint8_t *dst, size_t
> *dst_len,
> + uint8_t *src, size_t
> src_len);
This header should directly #include stdint.h and sys/types.h.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
