On 21/03/16 12:16, Diego Biurrun wrote:
> On Mon, Mar 21, 2016 at 12:02:41AM +0000, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/avconv_vaapi.c
>> @@ -0,0 +1,626 @@
>> +
>> +static void vaapi_device_uninit(AVHWDeviceContext *hwdev)
>> +{
>> +}
>> +
>> +int vaapi_device_init(const char *device)
>> +{
>> +}
>
> Are these two functions candidates for av_cold?
Probably? I'm not sure exactly what the test is. (If it's "only runs once per
stream", then all of that file except the get_buffer/retrieve_data should have
it. If it's "only runs once at all", then it should only be on the functions
you suggest.)
>> --- a/configure
>> +++ b/configure
>> @@ -4689,6 +4690,10 @@ enabled vaapi && enabled xlib &&
>> check_lib2 "va/va.h va/va_x11.h" vaGetDisplay -lva -lva-x11 &&
>> enable vaapi_x11
>>
>> +enabled vaapi &&
>> + check_lib2 "va/va.h va/va_drm.h" vaGetDisplayDRM -lva -lva-drm &&
>> + enable vaapi_drm
>
> Merging the two vaapi blocks would be cleaner IMO.
Do you mean:
if enabled vaapi ; then
check_lib2 "va/va.h va/va_x11.h" vaGetDisplay -lva -lva-x11 &&
enable vaapi_x11
check_lib2 "va/va.h va/va_drm.h" vaGetDisplayDRM -lva -lva-drm &&
enable vaapi_drm
fi
?
Referring back to a previous response, can you offer any guidance about how you
think the "vaapi", "vaapi_encode" etc. config options should be arranged?
(Including replacing existing "vaapi" with "vaapi_decode", I think.)
Thanks,
- Mark
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
