On Sat, Apr 2, 2016 at 5:09 PM, Luca Barbato <[email protected]> wrote:
> On 02/04/16 14:04, Luca Barbato wrote:
> > On 01/04/16 17:33, James Almer wrote:
> >> On 3/31/2016 10:22 PM, Tim Walker wrote:
> >>> Change log level from warning to debug: the E-AC-3 "core"
> >>> substream can be successfully decoded without the additional
> >>> and dependent substreams, and their presence is already
> >>> indicated via avpriv_request_sample in ff_eac3_parse_header.
> >>> ---
> >>> libavcodec/ac3dec.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c
> >>> index 97ce287..1161992 100644
> >>> --- a/libavcodec/ac3dec.c
> >>> +++ b/libavcodec/ac3dec.c
> >>> @@ -1347,7 +1347,7 @@ static int ac3_decode_frame(AVCodecContext *
> avctx, void *data,
> >>> /* skip frame if CRC is ok. otherwise use error
> concealment. */
> >>> /* TODO: add support for substreams and dependent frames
> */
> >>> if (s->frame_type == EAC3_FRAME_TYPE_DEPENDENT ||
> s->substreamid) {
> >>> - av_log(avctx, AV_LOG_WARNING, "unsupported frame type
> : "
> >>> + av_log(avctx, AV_LOG_DEBUG, "unsupported frame type :
> "
> >>> "skipping frame\n");
> >>
> >> Maybe AV_LOG_VERBOSE? Also, it could actually mention what kind of frame
> >> type is being skipped.
> >>
> >
> > I prefer keeping it as debug, reporting the frame type is a good idea
> > though.
> >
>
> Looks like it would be a redundant message if I understood the error
> path correctly.
>
> lu
Well, it's definitely redundant before my patchset. Afterwards, the
avpriv_request_sample is only printed once, so it's (slightly) less
redundant).
Is there any sort of agreement about what I should do, before I amend the
patch?
Tim
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
