On 03/05/16 15:34, Kieran Kunhya wrote: > I disagree, the old names are relatively clear. Whilst I think the speed > improvements in this patch are great, the function names like > bitstream_read_32 > are really confusing. IMO adding a number suffix should be the exception > rather than the norm (i.e when reading large numbers of bits).
The past code shown that not having the number of bits would make people assume such functions work for the wrong range. The new functions support a larger range BUT I had bitten once too many to consider using _long for the 63 bits variant. (the 32bit variant is sadly needed so we can't just have one with tha 0-63 range) lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
