On Wed, 24 Aug 2016, Diego Biurrun wrote:
This avoids SIMD-optimized functions having to sign-extend their
line size argument manually to be able to do pointer arithmetic.
---
libavcodec/arm/vp3dsp_init_arm.c | 6 +++---
libavcodec/ppc/vp3dsp_altivec.c | 4 ++--
libavcodec/vp3dsp.c | 20 ++++++++++----------
libavcodec/vp3dsp.h | 10 +++++-----
libavcodec/x86/vp3dsp_init.c | 15 +++++++--------
5 files changed, 27 insertions(+), 28 deletions(-)
diff --git a/libavcodec/arm/vp3dsp_init_arm.c b/libavcodec/arm/vp3dsp_init_arm.c
index 11e1f1c..1c91434 100644
--- a/libavcodec/arm/vp3dsp_init_arm.c
+++ b/libavcodec/arm/vp3dsp_init_arm.c
@@ -23,9 +23,9 @@
#include "libavutil/arm/cpu.h"
#include "libavcodec/vp3dsp.h"
-void ff_vp3_idct_put_neon(uint8_t *dest, int line_size, int16_t *data);
-void ff_vp3_idct_add_neon(uint8_t *dest, int line_size, int16_t *data);
-void ff_vp3_idct_dc_add_neon(uint8_t *dest, int line_size, int16_t *data);
+void ff_vp3_idct_put_neon(uint8_t *dest, ptrdiff_t stride, int16_t *data);
+void ff_vp3_idct_add_neon(uint8_t *dest, ptrdiff_t stride, int16_t *data);
+void ff_vp3_idct_dc_add_neon(uint8_t *dest, ptrdiff_t stride, int16_t *data);
Why are you renaming the parameter at the same time? That's not what I
would have expected of such a patch, especially since you do not mention
it in the commit message.
Your commit message also says
"This avoids SIMD-optimized functions having to sign-extend their line
size argument manually to be able to do pointer arithmetic."
while the patch actually does not at all remove this exact sign extension
that you say it tries to fix.
Not ok until you actually remove the sign extension from the corresponding
assembly at the same time.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
