On Wed, Aug 24, 2016 at 02:10:05PM +0300, Martin Storsjö wrote:
> On Wed, 24 Aug 2016, Diego Biurrun wrote:
> > --- a/libavcodec/arm/vp3dsp_init_arm.c
> > +++ b/libavcodec/arm/vp3dsp_init_arm.c
> > @@ -23,9 +23,9 @@
> >
> > -void ff_vp3_idct_put_neon(uint8_t *dest, int line_size, int16_t *data);
> > -void ff_vp3_idct_add_neon(uint8_t *dest, int line_size, int16_t *data);
> > -void ff_vp3_idct_dc_add_neon(uint8_t *dest, int line_size, int16_t *data);
> > +void ff_vp3_idct_put_neon(uint8_t *dest, ptrdiff_t stride, int16_t *data);
> > +void ff_vp3_idct_add_neon(uint8_t *dest, ptrdiff_t stride, int16_t *data);
> > +void ff_vp3_idct_dc_add_neon(uint8_t *dest, ptrdiff_t stride, int16_t 
> > *data);
> 
> Why are you renaming the parameter at the same time? That's not what I 
> would have expected of such a patch, especially since you do not mention 
> it in the commit message.

C, neon, ppc, x86 use a random mix of "stride" and "line_size".

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to