On Wed, 24 Aug 2016, Diego Biurrun wrote:

This avoids SIMD-optimized functions having to sign-extend their
line size argument manually to be able to do pointer arithmetic.
---

Possibly this needs some changes for ARM, which I know nothing about.

No, no such changes are needed since we don't have aarch64 asm for this. On 32 bit ARM, int and ptrdiff_t have the same size.

The patch seems ok, although I would prefer it not to change parameter names, especially as long as the commit message doesn't mention it. (I'm much more accommodating to such changes if they actually are declared upfront instead of sneaked in without mention.)

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to