On Wed, May 10, 2017 at 12:03 PM, Ricardo Constantino <[email protected]> wrote: > This is mostly a nitpick that's not caused by the patch but could be > addressed > while a new API is being made. > > Layouts "6.1" and "7.1(wide)" seem to be repeated in channel_layout_map. Is > there > any reason why (they're in some spec like that) or could they be changed to > something > like "6.1" and "6.1(back)" and "7.1(wide)" and "7.1(wide-side)" (or > "7.1(wide-back)") > in another patch? > > More exactly, change > { "6.1", AV_CHANNEL_LAYOUT_6POINT1 }, > { "6.1", AV_CHANNEL_LAYOUT_6POINT1_BACK }, > [...] > { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE }, > { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK }, > > to (like FFmpeg) > { "6.1", AV_CHANNEL_LAYOUT_6POINT1 }, > { "6.1(back)", AV_CHANNEL_LAYOUT_6POINT1_BACK }, > [...] > { "7.1(wide-side)",AV_CHANNEL_LAYOUT_7POINT1_WIDE }, > { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK }, > > or > { "6.1", AV_CHANNEL_LAYOUT_6POINT1 }, > { "6.1(back)", AV_CHANNEL_LAYOUT_6POINT1_BACK }, > [...] > { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE }, > { "7.1(wide-back)",AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK }, > > I don't really understand why FFmpeg went with wide-side instead of > wide-back, but it's > probably following the same logic as the other "side" variants (usage of > SL+SR instead > of BL+BR). Just differentiating the two different layouts would be fine, so > there's no need > to bikeshed too much.
No particular objection about this, anybody against? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
