On Wed, Jun 7, 2017 at 4:53 PM, wm4 <[email protected]> wrote: > On Wed, 7 Jun 2017 16:42:32 +0200 > Steve Lhomme <[email protected]> wrote: > >> On Wed, Jun 7, 2017 at 12:06 PM, wm4 <[email protected]> wrote: >> > On Wed, 7 Jun 2017 08:59:24 +0200 >> > Steve Lhomme <[email protected]> wrote: >> > >> >> On Tue, Jun 6, 2017 at 6:51 PM, wm4 <[email protected]> wrote: >> > >> >> > +static int d3d11va_device_create(AVHWDeviceContext *ctx, const char >> >> > *device, >> >> > + AVDictionary *opts, int flags) >> >> > +{ >> >> > + AVD3D11VADeviceContext *device_hwctx = ctx->hwctx; >> >> > + HANDLE d3dlib; >> >> > + >> >> > + HRESULT hr; >> >> > + PFN_D3D11_CREATE_DEVICE createD3D; >> >> > + IDXGIAdapter *pAdapter = NULL; >> >> > + ID3D10Multithread *pMultithread; >> >> > + UINT creationFlags = D3D11_CREATE_DEVICE_VIDEO_SUPPORT; >> >> >> >> It may be nice to be able to load d3d11_1sdklayers.dll optionally to >> >> debug leaks and have more debug messages when error occurs. Probably >> >> using a value in flags. >> > >> > Yes, that could be added later, if that's fine. I'm also not sure how >> > to load the DLL, or rather what to do with it once it's loaded. >> >> You don't do anything with it. But it provides fancy debug messages >> when you're doing something you shouldn't be doing. >> >> This is how we enable it in VLC >> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/video_output/win32/direct3d11.c;h=e9fcb83dcabfe778f26e63d19f218caf06a7c3ae;hb=HEAD#l1482 > > Why does it immediately unload it? Is it just for checking whether it > exists?
Yes, otherwise if you set the flag and the DLL doesn't exist, it will fail to create the device. > But yes, this could definitely be added to the Libav code. > >> And since you use the DXGI API you may also enable debugging of DXGI: >> >> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/avcodec/d3d11va.c;h=85e7d25caebc059a9770da2ef4bb8fe90816d76d;hb=HEAD#l599 > > Seems like a good idea too. > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
