> -----Original Message-----
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Diego
> Sent: February 11, 2018 1:00 PM
> To: libav development <firstname.lastname@example.org>
> Subject: Re: [libav-devel] Add HW H.264 and HEVC encoding for AMD GPUs
> based on AMF SDK
> On Thu, Feb 08, 2018 at 03:17:03PM +0100, Diego Biurrun wrote:
> > On Wed, Feb 07, 2018 at 06:39:39PM +0000, Mironov, Mikhail wrote:
> > > I quickly searched but did not find any formal standard on include guards.
> I did see some recommendations in forums though.
> > I suggest searching the C99 standard instead of random forums:
> > ISO/IEC 9899:1999 (E)
> > 7.1.3 Reserved identifiers
> > — All identifiers that begin with an underscore and either an
> > uppercase letter or another underscore are always reserved for any use.
> > > To get some statistics: I checked few header files in Windows SDK,
> OpenCL SDK, OpenGL, Intel Media SDK - I see all kind of styles including
> > > For example:
> > > https://github.com/Intel-Media-
> > > mfxvideo.h
> > Yes, bad practices abound. People look at kernel headers or libc
> > headers and wrongly believe that that is the example to follow. Then
> > others look at other projects for inspiration and cargo cult the error
> > Please be a good example and fix it instead of perpetuating this
> > malpractice. It's as easy as
> > find . -name \*.h | xargs sed -i -e 's/ __AMF\(.*\)__/ AMF_\1/'
> > from the root of the AMF source tree or the include dir (requires GNU sed).
> Did that for you, please apply the attached patch.
HI, Thanks for the patch. I will use it but the update will be pushed later.
The upcoming update
already branched out and is kind of locked for any but critical change. It will
Please understand that AMF code is used to build several binaries in the driver
and changes go through certain protocol.
libav-devel mailing list