On Wed, Feb 11, 2009 at 9:30 PM, Jan Safranek <[email protected]> wrote: > Hello, > > I played with Makefile a little bit and I am slightly uncomfortable with > current directory structure - all the source files lay on one pile, > library, tools and daemon together and it's a bit messy. > > Wouldn't it be better to have src/ directory, tools/ and maybe daemon/ > subdirs, where it would be nice and separated? It's quite hard to send > patches, IMHO it's better done directly in SVN. > > Proposal: > > dist/ > libcgroup.spec > mktarball.in > > include/ > libcgroup.h > > src/ > Makefile > config.h > api.c > lex.yy + generated stuff ? > wrapper.c > config.c (is it part of the library?) > > src/tools > Makefile > cgclassify.c > cgexec.c > cgconfig.c > > src/daemon > Makefile > cgrulesengd.c > cgrulesengd.h > > src/pam > pam_cgroup.c >
Looks good to me, do you want to send a patch to do this. Remember to update the spec file as well. > > The Makefile.in would get a bit more complicated (should we use > automake?), especially if we wanted --disable-daemon, --disable-pam or > other switches. > > IMO it's better to set some structure now than later, when there might > be more tools and dependencies... > I like this as well. I never got to using automake, but I'd love to use. Patches are welcome! Thanks for looking into this, Balbir ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
