On Wed, Feb 11, 2009 at 05:00:43PM +0100, Jan Safranek wrote: > Hello, > > I played with Makefile a little bit and I am slightly uncomfortable with > current directory structure - all the source files lay on one pile, > library, tools and daemon together and it's a bit messy. > > Wouldn't it be better to have src/ directory, tools/ and maybe daemon/ > subdirs, where it would be nice and separated? It's quite hard to send > patches, IMHO it's better done directly in SVN. >
Ys, I like this idea. Originally this was the plan, but things sort of spiralled out of control. > Proposal: > > dist/ > libcgroup.spec > mktarball.in > > include/ > libcgroup.h > > src/ > Makefile > config.h > api.c > lex.yy + generated stuff ? > wrapper.c > config.c (is it part of the library?) > > src/tools > Makefile > cgclassify.c > cgexec.c > cgconfig.c > > src/daemon > Makefile > cgrulesengd.c > cgrulesengd.h > > src/pam > pam_cgroup.c > > > The Makefile.in would get a bit more complicated (should we use > automake?), especially if we wanted --disable-daemon, --disable-pam or > other switches. > automake would be cool :). > IMO it's better to set some structure now than later, when there might > be more tools and dependencies... > Do you have any pending patches apart from those being reviewed? These changes will cause a fair rework of anything pending. Let's get the pending patches in, and then do the rework of the sources? What do you say? -- regards, Dhaval ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
