On 10/22/2009 04:49 PM, Balbir Singh wrote: > * Jan Safranek<[email protected]> [2009-10-22 15:17:57]: > >> Hi, >> >> as I promised to Balbir, here is patch which puts PAM module to standalone >> subpackage. And while fixing this, I've also tuned the spec file a bit. >> > > Jan, > > I am just beginning to test the patches, I realized since we split > the pam library, we also need the patch below otherwise, I see > that we end up linking with libpam, which we really don't need.
I am not sure I understand the patch... Subpackages work in a way that the sources are compiled *once* and various files are distributed to different subpackages - i.e. to have pam_cgroup.so in libcgroup-pam, you must compile *whole* package with --enable-pam (and pam-devel and /usr/include/security/pam_modules.h). And all packages resulting from one source package should have the same License: field. If you want to compile libcgroup once without pam to get libcgroup.rpm and for second time with pam to get libcgroup-pam, you need two separate source packages. Or very ugly hacks in the .spec files. If License: is the problem here, you can have two licenses here, one for the libcgroup library and second for the pam module. > > Signed-off-by: Balbir Singh<[email protected]> > --- > diff --git a/configure.in b/configure.in > index 8e2a40a..b26a84a 100644 > --- a/configure.in > +++ b/configure.in > @@ -50,17 +50,6 @@ AC_ARG_ENABLE([tools], > [with_tools=true]) > AM_CONDITIONAL([WITH_TOOLS], [test x$with_tools = xtrue]) > > -AC_ARG_ENABLE([pam], > - [AC_HELP_STRING([--enable-pam], > - [compile libcgroup PAM module [default=yes]])], > - [ > - if test "x$enableval" = xno; then > - with_pam=false > - else > - with_pam=true > - fi > - ], > - [with_pam=true]) > AM_CONDITIONAL([WITH_PAM], [test x$with_pam = xtrue]) > > AC_ARG_ENABLE([daemon], > ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
