On 10/22/2009 05:25 PM, Balbir Singh wrote: > * Jan Safranek<[email protected]> [2009-10-22 17:05:13]: > >> On 10/22/2009 04:49 PM, Balbir Singh wrote: >>> * Jan Safranek<[email protected]> [2009-10-22 15:17:57]: >>> >>>> Hi, >>>> >>>> as I promised to Balbir, here is patch which puts PAM module to standalone >>>> subpackage. And while fixing this, I've also tuned the spec file a bit. >>>> >>> >>> Jan, >>> >>> I am just beginning to test the patches, I realized since we split >>> the pam library, we also need the patch below otherwise, I see >>> that we end up linking with libpam, which we really don't need. >> >> I am not sure I understand the patch... Subpackages work in a way >> that the sources are compiled *once* and various files are >> distributed to different subpackages - i.e. to have pam_cgroup.so in >> libcgroup-pam, you must compile *whole* package with --enable-pam >> (and pam-devel and /usr/include/security/pam_modules.h). And all >> packages resulting from one source package should have the same >> License: field. >> >> If you want to compile libcgroup once without pam to get >> libcgroup.rpm and for second time with pam to get libcgroup-pam, you >> need two separate source packages. Or very ugly hacks in the .spec >> files. >> >> If License: is the problem here, you can have two licenses here, one >> for the libcgroup library and second for the pam module. >> > > With the changes I was able to get a build such that libcgroup.so is > not compiled with -lpam which is not required for the libcgroup.so > build. It is libcgroup-pam that needs pam. > > In src/pam/Makefile.am, we have an explicit > > pam_cgroup_la_LIBADD = $(top_srcdir)/src/.libs/libcgroup.la -lpam
Oh, now I start to understand! AC_CHECK_LIB([pam]...) adds -lpam to *all* resulting binaries and libs and that's what you are trying to avoid. Why don't you say it clearly :-] (Sorry, I must have been dumb, I should notice this earlier). Solution is easy, updated patchset follows. Jan ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
