On Mon, Nov 15, 2010 at 4:16 PM, Jan Safranek <[email protected]> wrote: > Add missing return value assignment, as pointed out by Steve Grubb. > > Signed-off-by: Jan Safranek <[email protected]> > --- > > src/tools/cgget.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/tools/cgget.c b/src/tools/cgget.c > index aad222a..10aa20e 100644 > --- a/src/tools/cgget.c > +++ b/src/tools/cgget.c > @@ -385,7 +385,7 @@ int main(int argc, char *argv[]) > goto err; > > if (mode & MODE_SHOW_ALL_CONTROLLERS) > - display_all_controllers(argv[i], argv[0], mode); > + ret = display_all_controllers(argv[i], argv[0], mode); > if (ret) > result = ret; >
While this is safe, for the sake of readiblity, would you mind moving the second if condition iinside the main if condition? Thanks! Dhaval ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
