On 11/15/2010 07:11 PM, Dhaval Giani wrote: > On Mon, Nov 15, 2010 at 4:16 PM, Jan Safranek<[email protected]> wrote: >> Add missing return value assignment, as pointed out by Steve Grubb. >> >> Signed-off-by: Jan Safranek<[email protected]> >> --- >> >> src/tools/cgget.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/tools/cgget.c b/src/tools/cgget.c >> index aad222a..10aa20e 100644 >> --- a/src/tools/cgget.c >> +++ b/src/tools/cgget.c >> @@ -385,7 +385,7 @@ int main(int argc, char *argv[]) >> goto err; >> >> if (mode& MODE_SHOW_ALL_CONTROLLERS) >> - display_all_controllers(argv[i], argv[0], mode); >> + ret = display_all_controllers(argv[i], argv[0], >> mode); >> if (ret) >> result = ret; >> > > While this is safe, for the sake of readiblity, would you mind moving > the second if condition iinside the main if condition?
Ok, I've also noticed a bug few lines above, so I'll send new patchset. Jan ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
