On Tue, Aug 13, 2013 at 10:07 PM, Weng Meiling <wengmeiling.w...@huawei.com> wrote: > On 2013/8/14 4:38, Dhaval Giani wrote: >> Hi, >> >> On Tue, Aug 13, 2013 at 6:24 AM, Weng Meiling >> <wengmeiling.w...@huawei.com> wrote: >>> >>> From: Weng Meiling <wengmeiling.w...@huawei.com> >>> >>> When setting the value of cgroup's control file by cgset -r, it's more >>> appositely to yield an error when user try to set a read-only file or >>> set a file not existed. So fix this by copying the dirty value in function >>> cgroup_copy_controller_values(). >>> >> >> I am not sure I understand the issue. Do you have a failing case? >> > In fact, it's just a problem about user experience. > > Example: > > # lscgroup > cpu:/ > cpu:/test > cpuset:/ > cpuset:/test > > if user set the control value which is not existed: > > # cgset -r cpu.share=1000 test > # > > or set a read-only control value: > > # cgset -r cpuset.memory_pressure=2 test > # > > as we can see, there is nothing when user do these operations, > is it better to yield an error to let user known what happen?:)
So in its current form, I refuse to apply the patch. We dont know whether applying the value failed because it was read-only, or because the name was wrong. This is just a hack, which might hide other issues later on. I would much rather have a check made (I am not sure where yet), which will confirm the file exists, and if so, check whether it is read only. Thanks! Dhaval ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
