On Wed, Sep 11, 2013 at 12:55 AM, Libo Chen <clbchenlibo.c...@huawei.com> wrote: > On 2013/9/11 11:13, Weng Meiling wrote: >>> >> as we can see, there is nothing when user do these operations, >>> >> is it better to yield an error to let user known what happen?:) >>> >>> So in its current form, I refuse to apply the patch. >>> >>> We dont know whether applying the value failed because it was >>> read-only, or because the name was wrong. This is just a hack, which >>> might hide other issues later on. I would much rather have a check >>> made (I am not sure where yet), which will confirm the file exists, >>> and if so, check whether it is read only. >>> >>> Thanks! >>> Dhaval > > From the user's perspective, if I do something, but can't get response even I > was wrong. > It is terrible, because maybe I will wrong continuously. > > So I am strong to fix this issue. > > We did some tests about this patch, it can deal with the case: file exists, > read only, or invalid value. > It is just fine for us, and didn't find other problem.
I think to some extent this patch papers over the problem. That code is starting to get quite complex. This bit doesn't make it easier. There are no comments why doing something is required. You do not have the maintenance burden. At this point, even though I don't have a better solution, unless you can convince me this will not increase maintenance costs, this patch is not getting merged. Thanks! Dhaval ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
