On Wed, 2007-01-03 at 13:23 -0800, Nishanth Aravamudan wrote:
> On 03.01.2007 [09:32:17 -0600], Adam Litke wrote:
> > On Tue, 2007-01-02 at 15:05 -0800, Nishanth Aravamudan wrote:
> > > I noticed that we currently put the "done"s from the segment remapping
> > > debugging on their own line. But I'm not sure I see the value, sine it
> > > seems rather out of place, given that we specifically use DEBUG_CONT().
> > > I think it looks cleaner (and saves up to two lines of screen space) to
> > > not newline-terminate the previous output.
> >
> > I think the main reason we always use newlines is to force a flush of
> > stderr to make sure we see the output right away. So, we could take
> > this patch, but then you'd need to add a call to fflush(stderr) in
> > each debug macro.
>
> Fair enough, doing so, though, causes the macros to become multi-line,
> and I had to add do { } while(0)s to preserve their statement-ness :)
> Seems like overkill, but I definitely prefer the formatting in the
> output.
>
> I noticed that we currently put the "done"s from the segment remapping
> debugging on their own line. But I'm not sure I see the value, sine it
> seems rather out of place, given that we specifically use DEBUG_CONT().
> I think it looks cleaner (and saves up to two lines of screen space) to
> not newline-terminate the previous output.
>
> Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
This seems okay to me. Does anyone else (David?) see an issue with
doing this?
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
