On 03.01.2007 [10:29:18 +1100], David Gibson wrote: > On Tue, Jan 02, 2007 at 03:05:56PM -0800, Nishanth Aravamudan wrote: > > I noticed that we currently put the "done"s from the segment remapping > > debugging on their own line. But I'm not sure I see the value, sine it > > seems rather out of place, given that we specifically use DEBUG_CONT(). > > I think it looks cleaner (and saves up to two lines of screen space) to > > not newline-terminate the previous output. > > Ah.. we need to be very careful about this. It may be this way > because if we're in line buffered mode and it dies in the remap you > won't see any of the message which is confusing. That can be worked > around with an explicit flush(), of course, but I'm not sure if we > have here.
See my updated patch. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
