On Fri, 2007-02-02 at 15:36 -0800, Nishanth Aravamudan wrote:

> Between this and the following patch, which is preferred?

Not a strong preference either way, but v1 looks a little cleaner. You
did miss one little thing though for which the below fixes (plus removes
an unneeded label). I'm running this through speccpu2000 now to check
for regressions.

elflink: fix new seginfo field name. remove old label.

Signed-off-by: Steve Fox <[EMAIL PROTECTED]>
---

--- libhugetlbfs-dev-20070129/elflink.c 2007-02-05 13:03:12.000000000 -0600
+++ libhugetlbfs-drftest/elflink.c      2007-02-05 12:54:31.000000000 -0600
@@ -568,9 +568,8 @@
 bail:
        DEBUG("Unable to perform minimal copy\n");
 bail2:
-       seg->extra_start = start_orig;
+       seg->extra_vaddr = start_orig;
        seg->extrasz = end_orig - start_orig;
-bail3:
        return;
 }
 

-- 

Steve Fox
IBM Linux Technology Center


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to