On 05.02.2007 [13:55:06 -0600], Jon Tollefson wrote:
> Nishanth Aravamudan wrote:
> >commit 7ad414f76f03f26fd148bf4100a83e238ac7af72
<snip>
> >-static void get_extracopy(struct seg_info *seg, void **extra_start,
> >- void **extra_end)
> >+static void get_extracopy(struct seg_info *seg)
> > {
> > Elf_Dyn *dyntab; /* dynamic segment table */
> > Elf_Sym *symtab = NULL; /* dynamic symbol table */
> >@@ -557,21 +556,21 @@ static void get_extracopy(struct seg_info *seg, void
> >**extra_start,
> >
> > if (found_sym) {
> > /* Return the copy window */
> >- *extra_start = start;
> >- *extra_end = end;
> >+ seg->extra_start = start;
> >+ seg->extra_end = end;
> > return;
> > } else {
> > /* No need to copy anything */
> >- *extra_start = start_orig;
> >- *extra_end = start_orig;
> >+ seg->extra_start = start_orig;
> >+ seg->extra_end = start_orig;
> > goto bail3;
> >
> I realize this isn't part of your changes, but I am new here. Is it
> useful to have 'goto bail3' go to a return instead of just having the
> return here?
I was trying to minimize my changes, mostly. Really, it should have been
a return (which I could have extracted out of both the if and the else
clauses, and placed just after them). But that's an independent cleanup
and didn't technically have to do with my changes, so I left it out.
TBH, in this case, it's small enough that I probably would have been a
bit more aggressive in my final revision. I just wanted to indicate the
different forms we could have.
Also, I think bail3 may have been used in multiple places before, and
now only in one. Generally, that's when we use gotos instead of direct
returns (but it's not strictly necessary here to use gotos).
In any case, none of this has been committed anywhere except my local
tree, so I'll make some further cleanups, probably based on v.1, and
repost the cleanup and the pagecache patches.
Thanks,
Nish
--
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
