On 04.07.2008 [09:37:31 +1000], David Gibson wrote:
> On Thu, Jul 03, 2008 at 10:04:01AM -0500, Andrew Hastings wrote:
> > David Gibson wrote:
> > > libhugetlbfs: Print summary of testsuite results
> > >
> > > This patch adds some tracking to the run_tests script which counts the
> > > total number of tests, and the number of passes, failures and other
> > > results. This is printed as a summary once the script is finished, so
> > > you can see at a glance if the tests ran clean or not.
> > >
> > > Signed-off-by: David Gibson <[EMAIL PROTECTED]>
> [snip]
> > > @@ -49,6 +74,9 @@ run_test () {
> > >
> > > skip_test () {
> > > echo "$@: SKIPPED"
> > > + for bits in $WORDSIZES; do
> > > + tot_skip=$[tot_skip + 1]
> > > + done
> > > }
> >
> > I was going to ask:
> > Shouldn't skip_test() also increment tot_tests[$bits]?
> > Shouldn't there be a [$bits] subscript on tot_skip?
>
> Yes, it should do both of these, of course. This patch evolved from
> a similar one I did for dtc, which uses roughly the same home-rolled
> test harness. But it doesn't have to mess about with multiple bitsize
> builds of things.
>
> Because skip_test was unused, I forgot to update it for the bitsize
> handling changes.
Are you going to repost the patch, David, or would you prefer I just
make the changes locally?
Thanks,
Nish
--
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
