On Wed, Jul 30, 2008 at 11:52:22AM -0700, Nishanth Aravamudan wrote:
> On 26.07.2008 [15:11:19 +0100], Andy Whitcroft wrote:
> > Report the library version in the debugging output.
>
> Doesn't this already happen in elflink.c elsewhere?
> Minimally, we shouldn't output redundant information.
> A better fix would be to remove it from elflink.c and put it in either
> debug.c or init.c
Actually we don't seem to dump out the version ever, we compile it into
the library so you can get it out with strings but never emit it.
That aside, yes this should not be in elflink particularly as that is
conditional on NO_ELFLINK. It feels much more appropriate in the debug
setup.
> > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
> > ---
> > elflink.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/elflink.c b/elflink.c
> > index ce1cf02..b1195fa 100644
> > --- a/elflink.c
> > +++ b/elflink.c
> > @@ -1097,6 +1097,8 @@ static int check_env(void)
> > char *env, *env2;
> > extern Elf_Ehdr __executable_start __attribute__((weak));
> >
> > + DEBUG("Version: " VERSION "\n");
> > +
> > env = getenv("HUGETLB_ELFMAP");
> > if (env && (strcasecmp(env, "no") == 0)) {
> > DEBUG("HUGETLB_ELFMAP=%s, not attempting to remap program "
> > --
> > 1.5.6.GIT
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Libhugetlbfs-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Libhugetlbfs-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
