On 31.07.2008 [13:19:06 +0100], Andy Whitcroft wrote:
> On Wed, Jul 30, 2008 at 11:52:22AM -0700, Nishanth Aravamudan wrote:
> > On 26.07.2008 [15:11:19 +0100], Andy Whitcroft wrote:
> > > Report the library version in the debugging output.
> >
> > Doesn't this already happen in elflink.c elsewhere?
> > Minimally, we shouldn't output redundant information.
> > A better fix would be to remove it from elflink.c and put it in either
> > debug.c or init.c
>
> Actually we don't seem to dump out the version ever, we compile it into
> the library so you can get it out with strings but never emit it.
Disagree, I see it in every test I run manually. <looks> Um,
elflink.c::__hugetlbfs_setup_elflink():
DEBUG("libhugetlbfs version: %s\n", VERSION);
> That aside, yes this should not be in elflink particularly as that is
> conditional on NO_ELFLINK. It feels much more appropriate in the debug
> setup.
That would be great, thanks,
Nish
--
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
