On Fri, Jun 13, 2008 at 3:12 PM, Roy Stogner <[EMAIL PROTECTED]> wrote:
>
> On Fri, 13 Jun 2008, Derek Gaston wrote:
>
>> On Jun 13, 2008, at 1:55 PM, Roy Stogner wrote:
>>> #include "libmesh/mesh/mesh.h"
>>
>> I personally think that maybe this should wait until after the 0.6.9
>> release... this is going to be a not small change for users to take...
>> which seems more like a 0.7 type of thing.
>
> My thinking is that we could ease into it gradually.  Start by moving
> the real headers into "include/libmesh/{base,geom,etc}/", but put
> stubs in "include/{base,geom,etc}" that include the real headers after
> a preprocessor macro announces a deprecated() warning.  Add
> include/ to the compiler's include path immediately, but don't remove
> include/* until a later version.  That way old code will still compile
> and work with 0.6.9 and 0.7.0, but everybody will have a chance to fix
> it before 0.8.0, just like with libMesh::init(), error(), and such.
>
>> Also, before we do such a thing I vote for a complete reorganization
>> of src and include.  If we're going to have to be typing /something/
>> whatever I want /something to make sense so I don't have to go look it
>> up all the time.  As it is now I have a really hard time remembering
>> which pieces are in which places.  For instance there  are
>> circumstances where base classes are in different directories from
>> child classes............
>
> Sometimes you want base classes in different directories from child
> classes: reference_counted_object.h, for instance.  But I agree with
> you in principle.  My personal pet peeve is
> include/mesh/mesh_function.h vs. src/numerics/mesh_function.C  ;-)

Agreed - let's fix the egregious ones like mismatched .C and .h
locations.  But a lot of these are just a matter of opinion: should
type_vector.h be in numerics/ or should it be in say utils/ or even
geom/ since it's the class that Point is based on?  If you move it,
you'll also have to move type_tensor.h, vector_value.h, etc.  Since
we've already (or should have already, Derek!) committed to memory the
fact that it's in numerics I think we should just leave it...

Likewise, it kind of bugs me that all the System header files are in
the solvers/ directory, and all the ErrorEstimators are in the
numerics/ directory, but again I know they are there so I'd just as
soon leave it alone.

@Derek: Aren't you using one of these new-fangled IDEs that all the
kids are talking about anyway?

-J

PS Get off my lawn!

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to