On Fri, 3 Dec 2010, [email protected] wrote:
> My vote would be to add it in the commit hook. There should be no > disadvantages that way and formatting will get better over time. > Heavily worked sections of code will come up to date quickly while > less busy sections of code (in terms of changes) may never come up > to speed. At least things won't get any worse over time. Slight disadvantage - every time a file was changed, we'd either need to figure out how to restrict astyle's actions to just the changed sections or we'd have to live with some of the same "svn blame" limitations when one small touch to a file ended up changing the whole thing. Practical problem: Sourceforge-hosted subversion seems to only support a limited selection of server-side hooks, none of which is an auto-indenter. Maybe I've just missed the right admin option? Good idea, in any case. Lots of other good ideas in the responses, too. The trick Chetan pointed out totally fixes the regression worries, and the command line option John pointed out fixes the diff and blame problems, which I think covers the main things Tim and I were bothered by. Any other major objections/objectors? If not, I'm now changing my vote to pro-astyle... I still don't want to make massive changes, even massive superficial changes, right before I go out of town for an extended trip, but anyone else who wants to do the testing can run us through astyle whenever; otherwise I'll find some convenient time to do it early next year. --- Roy ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
