On Wed, 30 May 2012, John Peterson wrote:
On Wed, May 30, 2012 at 3:01 PM, John Peterson <jwpeter...@gmail.com> wrote:Your second patch isn't really a great fix, since technically things should be initialized in the constructor in the order they are declared in the class, but, thinking about it for a moment, this constructor is just oddly-written in general: there's not really any need to call all these vector default constructors explicitly. Probably just really old code I'm guessing...should be fine to just delete all of those guys.Although svn blame tells me Roy added all these recently on 13 Jan 2011, so he will enlighten me hopefully.
Calling those constructors explicitly shouldn't change the generated code at all - doing so just wards off complaints from -Weffc++. --- Roy
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
