On Wed, 24 Oct 2012, Kirk, Benjamin (JSC-EG311) wrote:
Well in that case, a much less severe API change might be
Parallel::max(a);
becomes
Parallel parallel(MY_COMMUNICATOR);
…
parallel.max(a);
at least that one can be handed with only one line of new code and a
query/replace!
What's particularly pathetic isn't that I didn't think of this myself,
it's that I did think of it (quite some time ago), then forgot about
the idea, then today suggested an obviously grossly inferior idea
instead.
This is such an aesthetic improvement over the mess of default
Communicator arguments in parallel.h that I'd be tempted to change to
something like your proposed API regardless of other benefits. Move
the existing code from Parallel:: functions to Communicator member
functions, leave the Parallel::X() functions as libmesh_deprecated()
shims to libMesh::Communicator_World.X(), and old user code would
remain API compatible until the deprecated stuff got removed.
---
Roy
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
