On Wed, 24 Oct 2012, Paul T. Bauman wrote:
On Wed, Oct 24, 2012 at 12:32 PM, Roy Stogner <royst...@ices.utexas.edu> wrote:
This is such an aesthetic improvement over the mess of default
Communicator arguments in parallel.h that I'd be tempted to change to
something like your proposed API regardless of other benefits. Move
the existing code from Parallel:: functions to Communicator member
functions, leave the Parallel::X() functions as libmesh_deprecated()
shims to libMesh::Communicator_World.X(), and old user code would
+1, FWIW.
I haven't added the libmesh_deprecated() claims (and won't until all
library code is updated to use the new APIs, which will probably wait
until we decide on some name like libMesh::CommWorld to use as a
terser reference for libMesh::Parallel::Communicator_World), but the
basic task of moving APIs to Communicator and making the old global
functions into shims is done.
It's a particularly annoying "svn diff" to apply, since svn 1.6
doesn't support "--show-copies-as-adds" and patch doesn't like
symlinks, but here's how to apply from your LIBMESH_DIR:
wget http://users.ices.utexas.edu/~roystgnr/parallel_refactor.patch
svn copy include/parallel/parallel.h include/parallel/parallel_implementation.h
patch -p0 < parallel_refactor.patch
ln -sf ../parallel/parallel_implementation.h include/libmesh/
ln -sf ../parallel/parallel_communicator_specializations include/libmesh/
Extra testing would be appreciated.
---
Roy
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
