On Thu, 4 Nov 2010, Kirk, Benjamin (JSC-EG311) wrote: > What are the downsides of 1.)?
I'd also like to know this one. It looks as if the only downside is a memory leak in the case where a user accidentally ignores a Request rather than waiting for it to complete? And in that case we can just provide a Request::free() method to let it be ignored deliberately instead of accidentally. > When I implemented the request object I clearly misinterpreted the purpose > of MPI_Request_free(). > We should add a member Request::free() to do what the current > destructor does, although I don't think there is anywhere we need to > actually use it. There shouldn't be. And we might be able to catch any future problems at runtime. Could we add a libmesh_assert to the destructor, to make sure the request has been set to MPI_REQUEST_NULL (which I believe both the wait and free commands do)? --- Roy ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
