https://bugs.documentfoundation.org/show_bug.cgi?id=173936

--- Comment #12 from Justin L <[email protected]> ---
(In reply to Heiko Tietze from comment #6)
> b) styles are your friend
That simply is not true. Perhaps it is true in theory or in other situations,
but definitely it is not true in practice for table styles so far.

For example, you cannot even 'Table Insert' based on a custom user table style.

> c) we should consider alternatives such as "Clear the style".
That doesn't make any sense to me. It is much simpler for the user to have a
special 'None' entry than having a separate button or whatever. 

> Adding a command that removes all styling from a table sounds also right
That is expactly what 'AutoFormat Styles' is intended to do. So setting special
nIndex 0 (None) to be the same as nIndex -1 (nothing selected) should do the
trick nicely and consistently - and then it would also work for non-GTK3.

(SID_RESET_AUTOFORMATS seems to serve a slightly different purpose - only used
in AutoFormat Styles edit handler.)


(In reply to Justin L from comment #9)
> it adds a style written into the document, while the built-in ones don't. 
Not true - the built-in ones DO add the used style to styles.xml and as
template-name (at least for Table Insert and AutoFormat Styles).
Also not true that 'None' gets added to styles.xml or indicated as a template.
It doesn't because basesh.cxx InsertTableImpl explicitly skips pTAFormat when
aAutoName == SwViewShell::GetShellRes()->aStrNone.

Actually, Table Convert NEVER sets a template, SwDoc::InsertTable just seems to
use pTAFormat for defining the table but never setting it as the template.

So 'None' only gets added as a template for 'AutoFormat Styles'... and that is
easy to handle with a simple exception for Index 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to