https://bugs.documentfoundation.org/show_bug.cgi?id=114150
Julien Nabet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected], | |[email protected] --- Comment #1 from Julien Nabet <[email protected]> --- Caolán: Taking a look, I see for example: julien@debianamd:~/lo/libreoffice$ git grep -n STR_SVT_FILEPICKER_AUTO_EXTENSION fpicker/source/aqua/resourceprovider.mm:51: { CHECKBOX_AUTOEXTENSION, STR_SVT_FILEPICKER_AUTO_EXTENSION }, fpicker/source/office/iodlg.cxx:2070: m_xImpl->m_xCbAutoExtension->set_label( FpsResId( STR_SVT_FILEPICKER_AUTO_EXTENSION ) ); fpicker/source/win32/VistaFilePickerImpl.cxx:643: iCustom->AddCheckButton (nControlId, o3tl::toW(FpsResId(STR_SVT_FILEPICKER_AUTO_EXTENSION).replaceFirst("~","").getStr()), true); fpicker/source/win32/resourceprovider.cxx:55: { CHECKBOX_AUTOEXTENSION, STR_SVT_FILEPICKER_AUTO_EXTENSION }, include/fpicker/strings.hrc:14:#define STR_SVT_FILEPICKER_AUTO_EXTENSION NC_("STR_SVT_FILEPICKER_AUTO_EXTENSION", "~Automatic file name extension") julien@debianamd:~/lo/libreoffice$ git grep -n STR_FPICKER_AUTO_EXTENSION vcl/inc/strings.hrc:70:#define STR_FPICKER_AUTO_EXTENSION NC_("STR_FPICKER_AUTO_EXTENSION", "~Automatic file name extension") vcl/qt5/QtFilePicker.cxx:637: resId = STR_FPICKER_AUTO_EXTENSION; vcl/unx/gtk3/fpicker/resourceprovider.cxx:37: { CHECKBOX_AUTOEXTENSION, STR_FPICKER_AUTO_EXTENSION }, vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx:224: resId = STR_FPICKER_AUTO_EXTENSION; but there are other strings. I thought about removing those in vcl/inc/strings.hrc and use those from include/fpicker/strings.hrc What do you think? Unless fpicker dir should be removed at the end? I must recognize I don't understand why there's specific fpicker part whereas there's fpicker part too in vcl and in this last part we also see native file pickers. -- You are receiving this mail because: You are the assignee for the bug.
