https://bugs.documentfoundation.org/show_bug.cgi?id=114150

--- Comment #3 from Julien Nabet <[email protected]> ---
Thank you Caolán for your feedback.
After having read what you indicated, I did a make "git grep -n 'TranslateId
aId'" and found:
...
fpicker/inc/fpsofficeResMgr.hxx:13:inline OUString FpsResId(TranslateId aId) {
return Translate::get(aId, Translate::Create("fps")); };
...
include/editeng/eerdll.hxx:34:OUString EDITENG_DLLPUBLIC EditResId(TranslateId
aId);
include/sfx2/sfxresid.hxx:26:SFX2_DLLPUBLIC OUString SfxResId(TranslateId aId);
include/svtools/svtresid.hxx:28:SVT_DLLPUBLIC OUString SvtResId(TranslateId
aId);
include/svx/dialmgr.hxx:27:SVXCORE_DLLPUBLIC OUString SvxResId(TranslateId
aId);
...
vcl/source/app/svdata.cxx:259:OUString VclResId(TranslateId aId)
...

so it could be a 3rd steps plan:
1)
- move "fpsofficeResMgr.hxx" from "fpicker/inc" to "include/fpicker"
- keep strings in include/fpicker/
- change required files so build is ok
build to check it's ok

2)
- modify vcl files which have dups so it uses FpsResId
build to check it's ok

3)
- remove duplicate strings from vcl
build to check it's ok


As an alternative, but which would perhaps require more work, would it be
relevant to merge fpicker part in vcl?
After all, if gtk part is in vcl, why not the other fpickers?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to