On Tue, 23 Dec 2008, Peter Stuge wrote: > Why is there even a base64_decode() in libssh2? OpenSSL does b64. Do > we have our own because libgcrypt doesn't have it? Hm. It's in GNU > crypto stuff for Java, maybe libgcrypt should add it?
I don't see the need even if OpenSSL and the others won't have it. What makes libssh2 users particularly interested in this? > Also it isn't heavily used in libssh2 so we could even change it to let the > caller alloc, or to always use malloc, or.. I'd prefer a version that doesn't use malloc at all but leaves that to the parent function (malloc is not a real fix since there are systems with different memory systems so 'free' cannot free memory a library allocated with malloc easily anyway). > I think letting the caller alloc would be the simplest change, it does > change how the function works though. Patch welcome? Perhaps we should just remove it from the public API, bump the soname (due to the removal) and make sure we don't use any alloc for it internally? I think that is pretty safe to do, I doubt libssh2 has _that_ many users (especially that use the base64 decoding in libssh2). -- / daniel.haxx.se ------------------------------------------------------------------------------ _______________________________________________ libssh2-devel mailing list libssh2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libssh2-devel
