On 25 Oct 2021 15:33, Richard Purdie wrote: > The name of the system contains the string "nios2". This string > is caught by the some of the greedy checks for OS/2 in libtool, > in particular the *os2* branches of switch statements match for > the nios2 string, which results in incorrect behavior of libtool. > > This patch adds an explicit check for *nios2* before the *os2* > checks to prevent the OS/2 check incorrectly trapping the nios2 > as well.
i don't think this is the right approach. this is adding another substring search across the entire space (cpu/vendor/os). we should fix the search so it uses the right value only to match against. > --- a/build-aux/ltmain.in > +++ b/build-aux/ltmain.in > > case $host in > + # For NIOS2, we want to make sure that it's not caught by the > + # more general OS/2 check below. Otherwise, NIOS2 is the same > + # as the default option. > + *nios2*) > + opt_duplicate_compiler_generated_deps=$opt_preserve_dup_deps > + ;; > # Solaris2 added to fix > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16452 > # see also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59788 > *cygwin* | *mingw* | *pw32* | *cegcc* | *solaris2* | *os2*) these should only match $host_os, and remove the leading glob at the same time. same for the other changes in this patch. -mike
signature.asc
Description: PGP signature