Hi Laurent, On Thu, 30 Nov 2006 22:09:26 -0000, Laurent Sansonetti <[EMAIL PROTECTED]> wrote:
>> There are just a couple of things I'd propose: maybe we should rename >> XML::Reader.walker to XML::Reader.document, and also alias >> XML::Reader.new >> to XML::Reader.string. IMO it seems more consistent (all constructors >> named for the argument they take). > > Good ideas. > > Maybe we could perhaps add XML::Document#reader that would do > XML::Reader.walker(self). > Good thinking, that'd be a handy addition. >>> The patch contains some test cases, but everything is not >>> covered (yet). Also, there is no RDoc comments yet, I would like to >>> be >>> sure that you agree with the API before starting to document it :) >> >> I wonder, any chance you might join the project, commit this patch, >> and >> document it in CVS? That way, you'll be able to help maintain the >> code too >> ;) > > Sure, I would be honored. My rubyforge username is 'lrz'. > Cool. I've added you to the project, and you should have commit rights now, so please go ahead and merge your patch straight to HEAD. Welcome aboard! Cheers, Ross -- Ross Bamford - [EMAIL PROTECTED] _______________________________________________ libxml-devel mailing list libxml-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/libxml-devel
