On Mon, 04 Dec 2006 23:44:17 -0000, Laurent Sansonetti <[EMAIL PROTECTED]> wrote:
> Hi Ross, > > On Dec 2, 2006, at 11:00 AM, Ross Bamford wrote: > >> On Thu, 30 Nov 2006 22:09:26 -0000, Laurent Sansonetti >> <[EMAIL PROTECTED]> >> wrote: >> >>>> There are just a couple of things I'd propose: maybe we should >>>> rename >>>> XML::Reader.walker to XML::Reader.document, and also alias >>>> XML::Reader.new >>>> to XML::Reader.string. IMO it seems more consistent (all >>>> constructors >>>> named for the argument they take). >>> >>> Good ideas. >>> >>> Maybe we could perhaps add XML::Document#reader that would do >>> XML::Reader.walker(self). >> >> Good thinking, that'd be a handy addition. > > I added all of them. > >>>>> The patch contains some test cases, but everything is not >>>>> covered (yet). Also, there is no RDoc comments yet, I would like to >>>>> be >>>>> sure that you agree with the API before starting to document it :) >>>> >>>> I wonder, any chance you might join the project, commit this patch, >>>> and >>>> document it in CVS? That way, you'll be able to help maintain the >>>> code too >>>> ;) >>> >>> Sure, I would be honored. My rubyforge username is 'lrz'. >>> >> >> Cool. I've added you to the project, and you should have commit rights >> now, so please go ahead and merge your patch straight to HEAD. Welcome >> aboard! > > Excellent! I had trouble checkouting the project in the past days (it > looks like I got the same problem with another RubyForge project), but > now it's working. I merged the patch along with the suggestions. I > will add documentation soon. > Excellent, it all looks good from this end. I can't tell you how great it is that this is now in :) > I filed the CHANGELOG as well though it doesn't seem to be > maintained :-) What's the purpose of this file? It is only for major > changes? > It probably should be updated, but I tend to forget when I'm working on something in public version control (it's easy to grab a changelog from cvs or svn anyway). I guess it does make life easier for distribution package maintainers though, so I'll get around to updating it from the CVS logs in the next few days. Cheers, -- Ross Bamford - [EMAIL PROTECTED] _______________________________________________ libxml-devel mailing list libxml-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/libxml-devel
