Re: [libxml-devel] Reverting setup.rb to 3.4.1

[Charlie Savage]

Hi Trans,

As a result, I've checked in the older version.  Feel free to shout out
if this is the wrong thing to do.

Well, I'd like to know why the line wasn't working? The line was there
in order to support installation of documentation to standard OS
location --a 3.5.0 feature. If the line had a problem  finding the
file my guess is the package was also missing the meta/ directory.
Ultimately this line isn't the best solution, but it sufficed until a
better approach became apparent. That aside, a quick fix would have
been:

  PACKAGE = 'libxml-ruby'

which is all this effectively does.

I realize that there is a great energy moving things along right now.

Believe me, I more than anyone am happy to see it!

Sure, here is what I get:

$tar -xvzf libxml-ruby-0.7.1.tgz
$cd libxml-ruby-0.7.1
$ruby setup.rb

setup.rb:10:in `read': can't convert nil into String (TypeError)
        from setup.rb:10

Where:

Dir.glob('{.,meta/}unixname{,.txt}') returns []

So this breaks:




But I have to ask

PACKAGE = File.read(Dir.glob('{.,meta/}unixname{,.txt}', File::FNM_CASEFOLD).first).strip

you to consider a bit more why things may be the way they are. If

you're not sure then ask.

For instance, I just rechecked out the

Of course - which is why I posted a message to the mailing list saying what I did - my fix was temporary until I got further feedback.

current trunk, and I see that lib/libxml has been moved to to just

lib/.

That will break things very badly for anyone who installs using

Not sure what you mean here. Are you referring the files in that directory or are you referring to the requires in lib/libxml.rb?

setup.rb --in fact it will make a mess of their site_ruby directory!
Please move it back.

I agree the ruby/site_ruby directory does become a mess, and that putting files into a sub xml directory would be good. However, I didn't actually change that - its the same as it was before. The only change I made was splitting libxml.rb into separate files for easier maintenance. I didn't change the directory layout or file locations. So I'm not sure what needs to be reverted? I don't think mashing all the files back into a single file is a good idea. I do think movnig them into the xml subdirectory has some merit.

You can leave the 3.4.1 version of setup.rb for now. That's fine.
3.5.0 still needed a few tweaks --and as I said before I'd like to
replace it altogether anyway.

Charlie

I'm fine either way, setup.rb isn't my cup of tea. Just as long as what's checked-in works.

smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
libxml-devel mailing list
libxml-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/libxml-devel