On Jul 12, 6:41 pm, Charlie Savage <[EMAIL PROTECTED]> wrote:
> >> As a result, I've checked in the older version. Feel free to shout out
> >> if this is the wrong thing to do.
>
> > Well, I'd like to know why the line wasn't working? The line was there
> > in order to support installation of documentation to standard OS
> > location --a 3.5.0 feature. If the line had a problem finding the
> > file my guess is the package was also missing the meta/ directory.
> > Ultimately this line isn't the best solution, but it sufficed until a
> > better approach became apparent. That aside, a quick fix would have
> > been:
>
> > PACKAGE = 'libxml-ruby'
>
> > which is all this effectively does.
>
> > I realize that there is a great energy moving things along right now.
> > Believe me, I more than anyone am happy to see it!
>
> Sure, here is what I get:
>
> $tar -xvzf libxml-ruby-0.7.1.tgz
> $cd libxml-ruby-0.7.1
> $ruby setup.rb
>
> setup.rb:10:in `read': can't convert nil into String (TypeError)
> from setup.rb:10
>
> Where:
>
> Dir.glob('{.,meta/}unixname{,.txt}') returns []
>
> So this breaks:
>
> PACKAGE = File.read(Dir.glob('{.,meta/}unixname{,.txt}',
> File::FNM_CASEFOLD).first).strip
> But I have to ask
>
> > you to consider a bit more why things may be the way they are. If
> > you're not sure then ask.
>
> Of course - which is why I posted a message to the mailing list saying
> what I did - my fix was temporary until I got further feedback.
You're right. You did. I was meaning to focus on this in particular.
It was a meant more as general cautionary note for all of us.
> For instance, I just rechecked out the
>
> > current trunk, and I see that lib/libxml has been moved to to just
> > lib/.
>
> Not sure what you mean here. Are you referring the files in that
> directory or are you referring to the requires in lib/libxml.rb?
>
> That will break things very badly for anyone who installs using
>
> > setup.rb --in fact it will make a mess of their site_ruby directory!
> > Please move it back.
>
> I agree the ruby/site_ruby directory does become a mess, and that
> putting files into a sub xml directory would be good. However, I didn't
> actually change that - its the same as it was before. The only change I
> made was splitting libxml.rb into separate files for easier maintenance.
> I didn't change the directory layout or file locations. So I'm not
> sure what needs to be reverted? I don't think mashing all the files
> back into a single file is a good idea. I do think movnig them into the
> xml subdirectory has some merit.
No not lib/xml/, that's were we had been. we need the code under lib/
libxml/. the xml/ directory is there only for backward compatibility.
T.
_______________________________________________
libxml-devel mailing list
libxml-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/libxml-devel
