Comment #15 on issue 3473 by [email protected]: Patch: Rewrite
STEPMAKE_GET_VERSION.
http://code.google.com/p/lilypond/issues/detail?id=3473
I'm still -1 to the patch as it is. I don't want to alienate anybody, but
just like minimal examples are our best bet to identify the source of a
bug, minimal patches are our best bet to understand where potential new
regressions are introduced. So I would rather go with the minimal
meaningful change necessary to fix the problem, something like any of the
two one-liner that I will attach to this ticket now. The first patch just
parses stdout instead of both stdout and stderr, as discussed above. The
second, alternative patch changes the date parsing so that it isn't
confused by a git hash. This second approach seems to be part of Werner's
proposed changes, but it is complicated by the parsing of stdout before
stderr, rewriting to avoid eval, and extracting the logic to a bash
function.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
