On Mon, 21 Apr 2008 10:02:45 +0200 "Valentin Villenave" <[EMAIL PROTECTED]> wrote:
> 2008/4/21 Graham Percival <[EMAIL PROTECTED]>: > > > -- actually, it might therefore be better to add the "category" > > field to define-markup-command (or build-markup or whatever it's > > called) *without* using an optional argument. That would force > > programmers to give them a category (even if the category is > > simply "other"), which is exactly what we want. > > I'd prefer to (but it's just because I can't handle the code > otherwise ;) > > However, don't we risk a major breakage if doing so? How should I know? I assume that you're going to compile lilypond to check it; presumably that's what you did for your previous patch. If for some reason you can't compile lilypond yourself any more, send the patch to me and I'll try it on the GDP server. As long as git compiles and produces decent docs, I think it's safe to say that no "major breakage" has occurred. (also assuming that the code is of good quality, easy to maintain, etc) Cheers, - Graham _______________________________________________ lilypond-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/lilypond-devel
