Graham Percival wrote Saturday, November 27, 2010 12:59 AM
On Fri, Nov 26, 2010 at 11:31:06PM +0100, Valentin Villenave
wrote:
On Fri, Nov 26, 2010 at 10:41 PM, Trevor Daniels
<[email protected]> wrote:
> OK; I agree. Patch looks good.
Thanks! I've pushed this patch, and merged translation onto
master
What.
You pushed a huge patch onto git, with only a few hours of review
time. Notably, without any review or comments from Mark -- the
developer who first questioned the original commit.
I don't think that was unreasonable. This was correcting
an equally big patch which we all agreed was wrong, and
which was already in master. It was equivalent to reverting
the bad patch, but without destroying the good bits within
it. Both Carl and I had approved it.
The reprehensible behaviour was pushing the first big patch
without review, not the second.
Trevor
_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel
