On Tue, Sep 29, 2015 at 10:48 AM, Eryu Guan <eg...@redhat.com> wrote:
> On Tue, Sep 29, 2015 at 09:33:34AM +0100, Filipe Manana wrote:
>> On Tue, Sep 29, 2015 at 4:54 AM, Eryu Guan <eg...@redhat.com> wrote:
>> > On Sat, Sep 26, 2015 at 12:40:13PM +0100, fdman...@kernel.org wrote:
>> >> From: Filipe Manana <fdman...@suse.com>
>> >>
>> >> Test that an incremental send works after a file from the parent snapshot
>> >> gets replaced in the send snapshot by another one at the same exact
>> >> location, with the same name and with the same inode number.
>> >>
>> >> This test used to fail after the linux kernel commit 8b191a684968
>> >> ("Btrfs: incremental send, check if orphanized dir inode needs delayed
>> >> rename") and it's fixed by patch titled:
>> >>
>> >> "Btrfs: send, fix corner case for reference overwrite detection"
>> >
>> > I got "btrfs receive" error when testing this, with 4.3-rc1 kernel and
>> > btrfs-progs v4.2, not sure if this is expected
>>
>> Yes, it's expected.
>> The fix isn't yet in any kernel release (nor rc).
>
> Thanks for the clarification, I was somehow expecting a file md5 mismatch.
The expected failure is really btrfs receive to fail due to a an
invalid path (file name) being sent by the kernel.
The md5 digest check was added to the test just to verify that if the
kernel generates the correct path, at the end of the test we get the
correct file and not the old file (or something else due to some bug).
>
> Then the patch looks good to me.
>
> Reviewed-by: Eryu Guan <eg...@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
